-
Notifications
You must be signed in to change notification settings - Fork 14
Add mutli rev support for function describe
#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 82.25% // Head: 82.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 82.25% 82.23% -0.02%
==========================================
Files 25 25
Lines 3353 3367 +14
Branches 574 578 +4
==========================================
+ Hits 2758 2769 +11
- Misses 515 517 +2
- Partials 80 81 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@karajan1001, can you please post the new results of the profiling with this patch in the same way that you did on #144? Also before/after runtime for a real |
In iterative/dvc#8453. In the same repo, this version of describe runs 5 times faster than the previous one. (With the experiment) grows the difference will be even bigger. |
skshetry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have enough understanding about this on the exp side. So I'll leave this up to @pmrowla.
I will suggest considering RefsIterator or something similar concept that allows us to do this kind of thing, as it seems this way we may need to extend multiple APIs to support lists, breaking the API. Also repo.refs of dulwich comes to mind, but it's limited (but we can extend :) ).
Anyway, I'm okay with this for the time being. :)
fix: #144
In our current describe function we only accept one rev at a time and will try to get a reference for every reference in the repo. It will cost O(MN) in the
exp showin which we try to get a ref for every single experiment.