Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Dec 29, 2022

Closes #160

When GIT_SSH_COMMAND or GIT_SSH are set, use the specified command (via dulwich's subprocess vendor) instead of our asyncssh vendor.

@pmrowla pmrowla self-assigned this Dec 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Base: 80.92% // Head: 81.66% // Increases project coverage by +0.74% 🎉

Coverage data is based on head (5440102) compared to base (75e0b28).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   80.92%   81.66%   +0.74%     
==========================================
  Files          25       25              
  Lines        3397     3404       +7     
  Branches      586      587       +1     
==========================================
+ Hits         2749     2780      +31     
+ Misses        558      542      -16     
+ Partials       90       82       -8     
Impacted Files Coverage Δ
src/scmrepo/git/backend/dulwich/__init__.py 79.13% <66.66%> (+0.10%) ⬆️
src/scmrepo/git/backend/gitpython.py 64.42% <0.00%> (+1.07%) ⬆️
src/scmrepo/git/backend/pygit2.py 76.48% <0.00%> (+1.98%) ⬆️
tests/conftest.py 95.00% <0.00%> (+7.00%) ⬆️
src/scmrepo/utils.py 87.09% <0.00%> (+19.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla merged commit 52b5b4f into iterative:main Dec 29, 2022
@pmrowla pmrowla deleted the dulwich-git-ssh-command branch December 29, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dulwich: use subprocess ssh vendor if GIT_SSH or GIT_SSH_COMMAND env vars are set

2 participants