Use create root to instantiate React apps #1971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
use-create-root
branch
2 times, most recently
from
dd84557 to
0b5adc3
Compare
mattseddon
force-pushed
the
use-create-root
branch
from
0b5adc3 to
aa3942f
Compare
mattseddon
commented
Jul 4, 2022
| </style> | ||
| </head> | ||
| <body> | ||
| <div id="root"> |
Contributor
Author
There was a problem hiding this comment.
[F] This is the actual change. The rest is converting tabs to spaces.
wolmir
approved these changes
Jul 4, 2022
mattseddon
commented
Jul 4, 2022
| html, | ||
| body, | ||
| .react-root { | ||
| #root { |
Contributor
Author
There was a problem hiding this comment.
Changing to an ID selector so we don't have to set the class name on the element
|
Code Climate has analyzed commit 804b4f3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
Contributor
Author
|
I will merge this into dev now so it gets a good run before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1969 (comment)
https://stackoverflow.com/questions/71668256/deprecation-notice-reactdom-render-is-no-longer-supported-in-react-18