Comparison table drag and drop feedback #2064
Conversation
…omparison-d-n-d-feddback
sroy3
requested review from
julieg18,
mattseddon,
rogermparent and
wolmir
as code owners
| @@ -0,0 +1,3 @@ | |||
| export const idToNodeNode = (id: string) => | |||
| // eslint-disable-next-line unicorn/prefer-query-selector | |||
There was a problem hiding this comment.
This is needed to pass Windows tests. When not using getElementById we need a CSS.escape because of all the funky ids we have in both the experiments table and plots. CSS.escape does not seem to create a valid id query on Windows unfortunately.
sroy3
changed the title
| dragAndDrop( | ||
| headerB, | ||
| // eslint-disable-next-line testing-library/no-node-access | ||
| headerD.parentElement?.parentElement || headerD, |
There was a problem hiding this comment.
[Q] Can we follow up and wrap these calls in a function so we don't have eslint-disable all through the tests?
// eslint-disable-next-line testing-library/no-node-access
headerD.parentElement?.parentElement || headerD
There was a problem hiding this comment.
limit them to a single place like we try to do when using any
|
Code Climate has analyzed commit 0480689 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
3 participants
First 2 tasks of #1604
Screen.Recording.2022-07-19.at.1.31.44.PM.mov