Skip to content

Fix cell tooltip position on table column resize #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2022
Merged

Fix cell tooltip position on table column resize #2087

merged 3 commits into from
Jul 25, 2022

Conversation

@julieg18
Copy link
Contributor

@julieg18 julieg18 commented Jul 22, 2022

Screen.Recording.2022-07-22.at.11.57.46.AM.mov

Fixes #2037

@julieg18 julieg18 added the bug Something isn't working label Jul 22, 2022
@julieg18 julieg18 requested a review from mattseddon as a code owner July 22, 2022 16:59
@julieg18 julieg18 self-assigned this Jul 22, 2022
mattseddon
mattseddon approved these changes Jul 24, 2022
View reviewed changes
Copy link
Contributor

@mattseddon mattseddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to be wary of anything that gets left aligned. Not sure we have a test in place that will let us know we have a new bug. Might not be an issue. Just something to consider.

@julieg18
Copy link
Contributor Author

julieg18 commented Jul 25, 2022

We just need to be wary of anything that gets left aligned. Not sure we have a test in place that will let us know we have a new bug. Might not be an issue. Just something to consider.

This PR only updates the tooltips within the resizable table cells so we shouldn't be misaligning anything else :)

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jul 25, 2022

Code Climate has analyzed commit 33d6bff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.7%.

View more on Code Climate.

@julieg18 julieg18 merged commit 15be818 into main Jul 25, 2022
@julieg18 julieg18 deleted the fix-hint-position-on-resize branch July 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogermparent rogermparent Awaiting requested review from rogermparent

@sroy3 sroy3 Awaiting requested review from sroy3

2 more reviewers

@wolmir wolmir wolmir approved these changes

@mattseddon mattseddon mattseddon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@julieg18 julieg18

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If a column has resized, the hint is showing not in the right place

3 participants

@julieg18 @wolmir @mattseddon