Send initial YAML and JSON files right after language client starts (2/3) #2445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
approved these changes
Sep 23, 2022
| async start() { | ||
| await this.client.start() | ||
|
|
||
| const files = await findFiles('**/*.{yaml,json}', '.??*') |
Contributor
There was a problem hiding this comment.
[I] Needs Python files too.
Contributor
|
Suggestion: When we cannot open a file, i.e the symbol is a folder we could use Some example usage in |
julieg18
approved these changes
Sep 23, 2022
wolmir
force-pushed
the
dvc-lsp-initial-files-on-load
branch
from
79b66a2 to
b0096e7
Compare
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| export default { | ||
| devtool: 'source-map', | ||
| entry: r('./src/server'), | ||
| module: { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
wolmir
changed the title
wolmir
force-pushed
the
dvc-lsp-initial-files-on-load
branch
from
b0096e7 to
1f6a83b
Compare
|
Code Climate has analyzed commit 1f6a83b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard documents manager provided by the VSCode SDK is only aware of text documents that the user has already opened in the editor area.
This is annoying because we would expect a feature like Go to Definitions to be immediately aware of the params.yaml file for example.
To solve this problem this PR will create a custom request from the Client to the Server with an initial batch of interesting documents. For now they are any yaml or json files that are not inside a hidden folder.