Remove erroneous shape from vertical on hover line when shape dimension is added #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note: Should be able to test this with |
mattseddon
commented
Sep 28, 2022
| disable: false | ||
| disable: false, | ||
| symbolFillColor: 'transparent', | ||
| symbolStrokeColor: 'grey' |
Contributor
Author
There was a problem hiding this comment.
[F] Moved these as per the ask in #2452. Thought that the approach that I was going to take was going to be significantly different to this one.
Contributor
Author
|
Closes #1757 |
sroy3
approved these changes
Sep 28, 2022
|
Code Climate has analyzed commit cb9b020 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.9%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2452
I tried a lot of things to make this a general solution.
I ended up going with a specific solution to patch the template only for shapes. I think this is good enough to get us started and to the next iteration from the DVC team.
Screenshot
If users run into this issue then we can revisit but I think this is good enough for this iteration. I do not envisage many people needing/seeing shapes.