-
Notifications
You must be signed in to change notification settings - Fork 28
Bump min DVC version to 2.30.0 (Use status from exp show) #2521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1c8039 to
00eff29
Compare
| experiment: Experiment | ||
| ) => { | ||
| if (experiment.running) { | ||
| if (experiment.status === ExperimentStatus.RUNNING) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking for the status everywhere, should we add getters like isRunning(), isQueued()...
For python noobs like me, this means editing the |
00eff29 to
3fc2c76
Compare
3fc2c76 to
55d492c
Compare
julieg18
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@mattseddon |
|
Code Climate has analyzed commit 52ceabf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.8% (0.0% change). View more on Code Climate. |
2/3
main<- #2520 <- this <- #2535Accommodates the breaking change in treeverse/dvc#8318. We are moving from 2 boolean fields to an enum which will now include:
We cannot merge until the above PR is merged. I will also need to increase the
MIN_CLI_VERSION. I will raise follow-up PRs to indicate failed experiments in the table (another behaviour change).Branch for testing:
git+https://github.com/karajan1001/dvc.git@fix7986.