Increase coverage #3513
Increase coverage #3513
Conversation
There was a problem hiding this comment.
Took me way too long to realize why getThemeValue wasn't called unless I changed its name.
| 'src/**/*.{ts,tsx}', | ||
| '!**/*.test.*', | ||
| '!src/stories/*', | ||
| '!src/stories/**/*.{ts,tsx}', |
There was a problem hiding this comment.
Correctly removes the IconWrapper and IconWrappers components from the coverage.
…de-dvc into increase-coverage
|
We can drop the overall coverage requirement by a few percentage points but we need to get back on top of this. |
|
I guess if we are aiming for 95% the pass/fail for coverage should be 95% on a PR. Need to discuss what's meaningful this week in the retro. |
That make sense. |
|
Code Climate has analyzed commit 0422023 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
2 participants
A drop in the sea, but some quick wins to increase the coverage. Will try to increase more in upcoming PRs.