Skip to content

Conversation

@ptmt
Copy link

@ptmt ptmt commented Dec 23, 2016

Related: facebook/react-native@e1577df

Also requires updates in Example. So I guess, I left it here for those, who for some reasons want to update to RN@0.40.

@adrienbataille
Copy link

@ptmt Hi, can you please merge this PR? 0.40 is out already.

@jhampton
Copy link

jhampton commented Jan 6, 2017

Bumping the above PR

@avioli
Copy link

avioli commented Jan 10, 2017

This is a weird version change. Why bump major version and the RC? Why include a version bump commit at all? My understanding is that pull requests should be from a branch that doesn't affect the version, thus master is not the best use case.

React Native advises imports to use angle brackets: #import <React/RCT...>, not quotes #import "React/RCT...". Both work though, just a matter of prioritisation - double quotes first checks local directory, and if it doesn't find a match moves to system headers paths, whereas the angle brackets skips directly to the system paths.

@ptmt
Copy link
Author

ptmt commented Jan 10, 2017

@avioli You're right, as I said it was rush update (I forked and updated like 6-7 plugins). Now, when 0.40 is released it's time to make a proper pull request.

@ptmt ptmt closed this Jan 10, 2017
baskan pushed a commit to baskan/react-native-fs that referenced this pull request Jan 11, 2017
update readme npm install instructions acording to itinance#223 breaking changes. 
new users should be informed.
@baskan baskan mentioned this pull request Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants