Skip to content

Conversation

@ghbm-itk
Copy link
Member

@ghbm-itk ghbm-itk commented Nov 23, 2023

Changed

  • sap.opret_kundekontakt: Function 'opret_kundekontakter' made more stable.
  • sap.multi_session: Function 'spawn_session' is no longer hardcoded to 1080p screen size.
  • sap.multi_session: Arrange session windows moved to separate function.
  • Bunch o' linting.
  • run_tests.bat: Dedicated test venv.
  • readme: Updated readme.

Added

  • Changelog!
  • pylint.yml: Flake8 added.

Fixed

  • sap.multi_session: Critical bug in 'run_batches'.
  • tests.sap.login: Change environ 'SAP Login' for later tests.

@ghbm-itk ghbm-itk requested a review from rimi-itk November 24, 2023 10:00

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not https://keepachangelog.com/en/1.1.0/ (it's basically the same).

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that “Keep a Changelog” uses Reference-style Links on level 2 heading:

## [Unreleased]

## [1.1.1] - 2023-03-05[unreleased]: https://github.com/olivierlacan/keep-a-changelog/compare/v1.1.1...HEAD
[1.1.1]: https://github.com/olivierlacan/keep-a-changelog/compare/v1.1.0...v1.1.1[0.0.1]: https://github.com/olivierlacan/keep-a-changelog/releases/tag/v0.0.1

You should do this as well.

@ghbm-itk ghbm-itk merged commit 636603c into develop Nov 28, 2023
@ghbm-itk ghbm-itk deleted the feature/update-kundekontakt branch November 28, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAP.multi_session.spawn_sessions should not be hardcoded to a 1080p screen.

3 participants