Feature/os2web key hashi corp vault #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to get certificate. # Conflicts: # CHANGELOG.md # composer.json # modules/os2forms_digital_post/src/Helper/CertificateLocatorHelper.php # modules/os2forms_digital_post/src/Helper/DigitalPostHelper.php
rimi-itk
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Is this file still needed to create Drush commands? I've created Drush commands (in other projects) without having a drush.services.yml file, and it may depend on the version of Drush being used if the file is needed or not …
However, we should have a composer dependency on drush/drush and since
drupal/core 10.4.0 conflicts drush/drush (<12.4.3)we know that Drush 12 or later is in play.
Comment on lines
4
to
5
| - "@config.factory" | ||
| - "@key.repository" |
There was a problem hiding this comment.
Comment on lines
+5
to
+7
| use Drupal\Core\Config\ConfigFactoryInterface; | ||
| use Drupal\Core\Config\ImmutableConfig; | ||
| use Drupal\key\KeyRepositoryInterface; |
There was a problem hiding this comment.
We should note somewhere, e.g. in the changelog, that we're making this change (in a major release).
jekuaitk
force-pushed
the
feature/os2web_key
branch
from
fea276d to
cd3e855
Compare
jekuaitk
force-pushed
the
feature/os2web_key-hashi-corp-vault
branch
from
507ffb3 to
7749375
Compare
rimi-itk
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/#/tickets/showTicket/2726