Pre downloading the velocity default config to make patches work on first startup.

[Crafter-Y]

Hi, thanks for your great work!

I saw that your docker-minecraft-server uses the mc-image-helper image to download some common configs before startup. This enables patching before the server even starts.

mc     | [mc-image-helper] 17:48:08.397 INFO  : Created/updated 10 properties in /data/server.properties
mc     | [init] Replacing env variables in /data that match the prefix 'CFG_' ...
mc     | [mc-image-helper] 17:48:10.177 INFO  : Downloading /data/config/paper-world-defaults.yml from https://raw.githubusercontent.com/Shonz1/minecraft-default-configs/main/1.21.4/paper-world-defaults.yml
mc     | [mc-image-helper] 17:48:10.177 INFO  : Downloading /data/config/paper-global.yml from https://raw.githubusercontent.com/Shonz1/minecraft-default-configs/main/1.21.4/paper-global.yml
mc     | [mc-image-helper] 17:48:11.743 INFO  : Downloading /data/bukkit.yml from https://raw.githubusercontent.com/Shonz1/minecraft-default-configs/main/1.21.4/bukkit.yml
mc     | [mc-image-helper] 17:48:11.743 INFO  : Downloading /data/spigot.yml from https://raw.githubusercontent.com/Shonz1/minecraft-default-configs/main/1.21.4/spigot.yml
mc     | [init] Applying patch definitions from /patches

Since https://github.com/Shonz1/minecraft-default-configs also includes default configs for velocity/waterfall/bungeecord, I wonder if you could implement this functionality in docker-mc-proxy as well.

As of now, the container needs to be started once, then stopped and then started again for patches to apply.

Another solution for this may be to add a configuration option to add urls with their destinations to predownload plugin configs as well.

[itzg]

That's a great idea. In fact, I wondered for a moment if I had already done that 😄

Also, a PR would be great if you or someone else wants to port that over.

[KiyoNetcat]

Hi, unfortunately, this ended up breaking copying existing config files in /config. I created an issue about it in #264.