AUTO_CURSEFORGE doesn't work for Vault Hunters due to ToroHealth and LegendaryTooltips being client-side mods

[itzg]

Vault Hunters is still broken due to ToroHealth and LegendaryTooltips being client-side mods but not being labeled as such, so I assume your fix doesn't exclude them.

Originally posted by @DrWhoCares in #1893 (comment)

I've added the line CF_EXCLUDE_MODS: "3556931,4035921" which should be the IDs for the two mods, going based off what's being output from the crash report in the logs, but they're still erroring. The docs simply say, "passing a comma or space delimited list of project IDs via CF_EXCLUDE_MODS"
Am I doing something wrong with the syntax? There's no examples in the readme. I'm using docker-compose specifically. Do I need to do anything like removing the image and re-pulling it or something like that?

(Further comments were posted there)

[DrWhoCares]

I tried removing the image and stack entirely and trying again and no dice.
This is the docker-compose.yml file I'm using.

version: '3.8'

services:
  mc:
    image: itzg/minecraft-server
    volumes:
    - ./modpacks:/modpacks:ro
    - data:/data
    environment:
      EULA: "true"
      TYPE: AUTO_CURSEFORGE
      CF_PAGE_URL: https://www.curseforge.com/minecraft/modpacks/vault-hunters-1-18-2
      CF_EXCLUDE_MODS: "3556931,4035921"
      CF_FORCE_SYNCHRONIZE: "true"
      OVERRIDE_SERVER_PROPERTIES: "true"
      DIFFICULTY: "hard"
      ALLOW_FLIGHT: "true"
      OPS: "DrWhoCares"
      MAX_PLAYERS: 16
      PVP: "true"
      MEMORY: "16G"
      GUI: "false"
    ports:
      - "25565:25565"
    stdin_open: true
    tty: true
    restart: unless-stopped
volumes:
  data: {}

[itzg]

I'm able to recreate the issue even though I see the exclusions correctly passed into image helper. I'll debug over there...

[itzg]

Looking closer at debugs I think I figured it out. Those IDs are the file not project IDs. In the debugs I see

Download/confirm mod torohealth-1.18-forge-2.jar @ 245733:3556931

So 245733 was the actual ID for torohealth.

BTW, right at this moment I am enhancing the exclude/include to allow slugs or IDs. That would have helped this scenario.

And LegendaryTooltips is 532127

[DrWhoCares]

Ah I see, I was trying to follow the example in the readme, and I assumed I had it right since the url contains files/. It might be worth making the readme a bit more clear as well.
Just tried it with the new IDs and it does seem to be working now. Thanks for the help with this!

[itzg]

then they can be excluded by passing a comma or space delimited list of project IDs

I state "project IDs" specifically. I know it's still easy to mistake one for the other, but please suggest how to word clearer or better yet submit a PR.

[DrWhoCares]

Ah I see that I did misread and the example given is how to get the file ID, and there is no example given on how to get the project ID. I was following the example for the file ID, and didn't notice that the project ID is listed on the right.

[itzg]

Ah yes, I need to include a screenshot like you have there

[DrWhoCares]

Btw this can be closed as fixed if you like. Was user error but "fixed" with updated documentation.

[itzg]

I had forgotten to link #1931 with this issue. Thanks.