document that default RCON_PASSWORD = minecraft in README #1109
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because while experimenting with RCON, it's highly confusing why without a RCON_PASSWORD it happens to "just work" e.g. with https://github.com/willroberts/minecraft-client (which uses "minecraft" as the default password itself!) but not with https://github.com/itzg/rcon-cli (which has no default password). Default passwords are always a bad idea, and should ideally ideally just be removed (if you are willing to make that backward compatible breaking change).
itzg
approved these changes
Nov 5, 2021
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for the detail and the cautionary note. I don't really like default passwords either, so I'm not sure why I started with one there 😀 But yeah, at this point I've gotten that default stuck there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because while experimenting with RCON, it's highly confusing why without a RCON_PASSWORD it happens
to "just work" e.g. with https://github.com/willroberts/minecraft-client (which uses "minecraft" as the default password itself!)
but not with https://github.com/itzg/rcon-cli (which has no default password).
Default passwords are always a bad idea, and should ideally ideally just be removed (if you are willing to make that backward compatible breaking change).