Implement support for packwiz modpacks #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a working PR, and still needs testing. |
Contributor
Author
|
Tested PR build with the following options: docker run --rm -it -v $(PWD)/temp:/data \
-e 'TYPE=FABRIC' \
-e 'EULA=TRUE' \
-e 'PACKWIZ_URL=https://pepsidogs.github.io/pepsipack/pack.toml' \
docker.io/itzg/minecraft-server:test-itzg-1545903355First run successful: Second run successful: |
Contributor
Author
|
Tested overriding pack definitions (and adding additional mods) using the common docker run --rm -it -v $(PWD)/temp:/data \
-e 'TYPE=FABRIC' \
-e 'EULA=TRUE' \
-e 'PACKWIZ_URL=https://pepsidogs.github.io/pepsipack/pack.toml' \
-e 'MODPACK=https://pepsi.dog/minecraft/files/mods_v1.zip' \
docker.io/itzg/minecraft-server:test-itzg-1545903355Successful: |
Contributor
Author
|
@itzg I'm happy with the support of this in place so far. Happy to make changes to the code location and or execution order if desired! |
See https://packwiz.infra.link/ for packwiz information This commit adds support for packwiz server modpack definitions provided by the PACKWIZ_URL environment variable. Packwiz modpack definitions are processed before other mod definitions (MODPACK, MODS, etc.) to allow for additional processing/overrides the operator may want to perform (in case of mods not available via Modrinth/CurseForge, or where the pack is not maintained by the operator). We attempt to retrieve the latest bootstrap jar from Github if it doesn't already exist. If for any reason retrieving release information from Github isn't possible, we'll use the existing bootstrap jar if already available. Packwiz is pre-configured to show no GUI and only download server mods.
Stealthii
force-pushed
the
feature/packwiz
branch
from
4c85286 to
d90221a
Compare
Contributor
Author
|
Reworked that commit to match the 2-space formatting used elsewhere in the file. |
itzg
approved these changes
Dec 7, 2021
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Awesome! Thanks for adding this and introducing me to packwiz.
Owner
|
This is now merged and published for all of the image variants. |
Contributor
Author
|
Awesome! I took packwiz for a spin due to a new server with friends for 1.18, and the string of mod updates meant an automated solution was needed. The nice thing here is that the same set of fabric mods can be used against client/server, so automated updates are easier to handle. Created a PR (packwiz/packwiz-website#8) against the packwiz documentation to refer to the section in the docs here. |
|
👀 Thank you for contributing this! I use docker-minecraft-server personally so this is very useful for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://packwiz.infra.link/ for packwiz information
This PR adds support for packwiz server modpack definitions provided via the
PACKWIZ_URLenvironment variable.Packwiz modpack definitions are processed before other mod definitions (
MODPACK,MODS, etc.) to allow for additional processing/overrides the operator may want to perform (in case of mods not available via Modrinth/CurseForge, or where the pack is not maintained by the operator).We attempt to retrieve the latest bootstrap jar from Github if it doesn't already exist. If for any reason retrieving release information from Github isn't possible, we'll use the existing bootstrap jar if already available.
Packwiz is pre-configured to show no GUI and only download server mods. A relevant note to
README.mdhas been added to clarify this, and informs operators to check their packwiz definition is correct in case client mods are downloaded and cause such issues.