Skip to content

Conversation

@itzg
Copy link
Owner

@itzg itzg commented Jan 29, 2022

Will be able to streamline and improve robustness of build and test of all the Debian variants. That will cover all except the legacy Alpine build of java8 and the upcoming GraalVM base image, which is RPM based.

cc @shotah

@shotah
Copy link
Contributor

shotah commented Jan 29, 2022

@itzg Looks pretty good, lots of changes, but that is why we have the tests in there. I think my only feedback was provided directly via chat. This is a great implementation and I think it'll make it much easier to test and expand in the future. Example if it is reasonable or not to create build, test, and deploy workflows to pass the variants into to break up the build process, but definitely not needed.

@itzg
Copy link
Owner Author

itzg commented Jan 29, 2022

I'm going to investigate skipping the server download during tests at a later time. As I was about to integrate a stub server jar I realized that I also want to the tested version to float for some of the variants via

      VERSION: ${MINECRAFT_VERSION:-LATEST}

@itzg itzg merged commit eb69446 into master Jan 29, 2022
@itzg itzg deleted the test/matrix-builds branch January 29, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants