Added support for Pufferfish 1.19 #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Jun 15, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for addressing this. Can you see if that suggestion works?
Owner
|
I think this will help with #1556 |
bram-pkg
reviewed
Jun 16, 2022
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Contributor
Author
|
The code now uses the versionLessThan function and has been tested with both 1.17, 1.18 and 1.19 ! |
itzg
approved these changes
Jun 16, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
I'm sorry I gave you the suggestion logic inverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Pufferfish 1.19
Compilation & execution have been tested.