Add AUTOSTOP_USE_PKILL option to use pkill instead of kill in autostop feature #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Sep 1, 2022
Contributor
Author
|
@itzg it now uses pkill by default, has a flag to use sudo with it, and rewrote commit to reflect new behavior 👍🏼 Let me know what you think |
Add aditional AUTOSTOP_PKILL_USE_SUDO setting to run pkill with sudo
Contributor
Author
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some nonstandard environments (see fly.io for an example) that the
server itself will be PID 1 is not a given. By allowing the user to
choose to use pkill instead they can ensure the autostop feature will
work even in those environments.