Add option to skip generic pack checksum #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an option
SKIP_GENERIC_PACK_UPDATE_CHECK. The documentation alludes to this reducing time due to the lengthy SHA1 checksum process; however, the option just skips the generic pack being applied entirely.In the spirit of backward compatibility, I've left that option as-is while adding a new option
SKIP_GENERIC_PACK_CHECKSUMthat simply skips the checksum.--
As a side note, I'm not seeing where the checksum is actually used now. The function appears to apply the pack regardless of the sum file contents.