Skip to content

Conversation

@ChipWolf
Copy link
Contributor

Currently, there is an option SKIP_GENERIC_PACK_UPDATE_CHECK. The documentation alludes to this reducing time due to the lengthy SHA1 checksum process; however, the option just skips the generic pack being applied entirely.

In the spirit of backward compatibility, I've left that option as-is while adding a new option SKIP_GENERIC_PACK_CHECKSUM that simply skips the checksum.

--

As a side note, I'm not seeing where the checksum is actually used now. The function appears to apply the pack regardless of the sum file contents.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I really appreciate the help.

To answer your question, it is evaluated here

elif isTrue "${FORCE_GENERIC_PACK_UPDATE}" || ! checkSum "${sum_file}"; then

where checkSum is implemented here

function checkSum() {

@itzg itzg merged commit 46a09ed into itzg:master Nov 10, 2022
@ChipWolf
Copy link
Contributor Author

Thanks for adding this. I really appreciate the help.

To answer your question, it is evaluated here

elif isTrue "${FORCE_GENERIC_PACK_UPDATE}" || ! checkSum "${sum_file}"; then

where checkSum is implemented here

function checkSum() {

Ah got it, awesome. Thanks again! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants