Skip to content

Correct AUTO_CURSEFORGE to also include library mods #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Correct AUTO_CURSEFORGE to also include library mods #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be937b1
Correct AUTO_CURSEFORGE to also include library mods
itzg Jan 12, 2023
bea5c8e
For AUTO_CURSEFORGE add ability to exclude specific mods
itzg Jan 12, 2023
57cda29
Don't exclude curios
itzg Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ RUN easy-add --var os=${TARGETOS} --var arch=${TARGETARCH}${TARGETVARIANT} \
--var version=0.1.1 --var app=maven-metadata-release --file {{.app}} \
--from https://github.com/itzg/{{.app}}/releases/download/{{.version}}/{{.app}}_{{.version}}_{{.os}}_{{.arch}}.tar.gz

ARG MC_HELPER_VERSION=1.24.3
ARG MC_HELPER_VERSION=1.24.5
ARG MC_HELPER_BASE_URL=https://github.com/itzg/mc-image-helper/releases/download/${MC_HELPER_VERSION}
RUN curl -fsSL ${MC_HELPER_BASE_URL}/mc-image-helper-${MC_HELPER_VERSION}.tgz \
| tar -C /usr/share -zxf - \
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,8 @@ The following two examples both refer to version 1.0.7 of ATM8:
-e TYPE=AUTO_CURSEFORGE -e CF_SLUG=all-the-mods-8 -e CF_FILENAME_MATCHER=1.0.7
```

If there are mods that need to be excluded, such as ones that did not properly declare as a client mod via the file's game versions, then they can be excluded by passing a comma or space delimited list of project IDs via `CF_EXLUDE_MODS`

### Old approach

Enable this server mode by adding `-e TYPE=CURSEFORGE` to your command-line,
Expand Down
2 changes: 1 addition & 1 deletion scripts/start-configuration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ case "${TYPE^^}" in
;;

AUTO_CURSEFORGE)
exec "${SCRIPTS:-/}start-autoDeployCF" "$@"
exec "${SCRIPTS:-/}start-deployAutoCF" "$@"
;;

VANILLA)
Expand Down
8 changes: 8 additions & 0 deletions scripts/start-autoDeployCF → scripts/start-deployAutoCF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ if [[ $CF_FILENAME_MATCHER ]]; then
args+=(--filename-matcher="$CF_FILENAME_MATCHER")
fi

defaultModExcludes=(
363363 # extreme-sound-muffler
448233 # entityculling
574856 # rubidium
)
: "${CF_EXLUDE_MODS:=${defaultModExcludes[@]}}"
args+=(--exclude-mods="$CF_EXLUDE_MODS")

if ! mc-image-helper install-curseforge "${args[@]}"; then
log "ERROR failed to auto-install CurseForge modpack"
exit 1
Expand Down