Correcting and extending vanillatweaks example #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
approved these changes
Mar 17, 2023
| VERSION: ${MINECRAFT_VERSION:-LATEST} | ||
| VANILLATWEAKS_SHARECODE: MGr52E | ||
| REMOVE_OLD_VANILLATWEAKS: "TRUE" | ||
| vanillatweaks_file_datapacks_and_resourcepacks_and_craftingtweaks: |
Owner
There was a problem hiding this comment.
I'm not sure if I had noticed before this example file was one big list of services 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vanillatweaks example didn´t work, I got the following error:
mc_1 | [mc-image-helper] 12:41:54.892 ERROR : 'vanillatweaks' command failed. Version is 1.25.12
mc_1 | java.lang.NullPointerException: Cannot invoke "me.itzg.helpers.vanillatweaks.model.Type.toString()" because the return value of "me.itzg.helpers.vanillatweaks.model.PackDefinition.getType()" is null
When I checked the tests under tests/setuponlytests/vanillatweaks_file I noticed there were two missing entries in the JSON file.
I corrected this and added the examples for resourcepacks and craftingtweaks as well.
See also itzg/mc-image-helper#163