Skip to content

Conversation

@itzg
Copy link
Owner

@itzg itzg commented May 14, 2023

@itzg
Copy link
Owner Author

itzg commented May 14, 2023

@GeoDerp would be glad to get any review comments you have on this.

@GeoDerp
Copy link

GeoDerp commented May 14, 2023

@GeoDerp would be glad to get any review comments you have on this.

Looks good @itzg , considering its 11:29pm here Ill have a better look tomorrow morning if you like, when im awake. 😂

for the README.md
did you want to talk about:

  • MODRINTH_FORCE_MODLOADER_REINSTALL
  • MODRINTH_FORCE_SYNCHRONIZE
    ?

@itzg
Copy link
Owner Author

itzg commented May 14, 2023

Thanks! I might go ahead and merge in a little while, but I'll be glad to address any follow up comments.

As for those variables/arguments, I later realized that those are not useful like they were with AUTO_CURSEFORGE. So, to keep the docs simple and to the point, I'll wait until later if/when they need to be covered.

@itzg itzg merged commit 54f310e into master May 14, 2023
@itzg itzg deleted the feat/modrinth-modpacks branch May 14, 2023 18:09
@GeoDerp
Copy link

GeoDerp commented May 15, 2023

tweaked the ARM Azure Template to some support the modrinth modpack command. Have to look into it more deeply the next few days but im currently having some errors like: me.itzg.helpers.http.FailedRequestException: HTTP request of https://api.modrinth.com/v2/version/2.2.0 failed with 400 Bad Request: Fetching object content

https://github.com/GeoDerp/azure-minecraft-server/tree/modrinth

@itzg
Copy link
Owner Author

itzg commented May 15, 2023

@GeoDerp did you happen to set version ID to "2.2.0"? If so, that'll be the problem since it has to be the ID and not the name (at this time). I could probably enhance that since the version page URL support will pick out the version by name.

@itzg
Copy link
Owner Author

itzg commented May 16, 2023

...actually, give the latest image a try since #2130 allows for ID, name or number to be provided for the version. Also, the variable is now MODRINTH_VERSION.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Modrinth ModPacks

3 participants