Include Log4jPatcher #2148
Merged
Include Log4jPatcher #2148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamancini
pushed a commit
to adamancini/docker-minecraft-server
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CreeperHost/Log4jPatcher to patch the Log4Shell vulnerability for server types and versions that are not covered by existing measures. See #2101 for some of the affected versions.
The patcher is being applied for all server types between Minecraft version 1.7 - 1.18.0 (inclusive), even though server types VANILLA and PURPUR are already covered by their patched log4j configurations.
Alternatively it could be set up to only cover server types excluding unaffected server types, however in my limited testing the additional patching does not appear to cause any side effects.
As requested a
SKIP_LOG4J_PATCHERenvironment variable has been introduced to skip the patching, it will default to false if not specified. This should probably be added to the documentation.fixes #2101