Moving Java 19 to 20 and adding Alpine #2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
May 31, 2023
itzg
reviewed
May 31, 2023
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Can you address docs/versions/java.md comment? Put same in README or just don't bother changing that file.
shotah
changed the title
itzg
approved these changes
May 31, 2023
Owner
|
I'm not sure how the PR verify succeeded since there indeed isn't arm/v7 support: 
Looking at https://github.com/itzg/docker-minecraft-server/actions/runs/5135235013/jobs/9240377096#step:10:173 |
Owner
|
Oh...I had accidentally hard coded this: |
adamancini
pushed a commit
to adamancini/docker-minecraft-server
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing Alpine along for 1.19 and 1.20 MC releases