Skip to content

build: use multi-arch platforms in verify-pr #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 31, 2023
Merged

build: use multi-arch platforms in verify-pr #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dd5f342
build: use multi-arch platforms in verify-pr
itzg May 31, 2023
6f6db24
Update build-multiarch.yml
itzg May 31, 2023
25b0f5b
Update docs java.md
itzg May 31, 2023
77d11e0
Separate out multi-arch part of verification
itzg May 31, 2023
dad6f45
Use linux/arm64/v8
itzg May 31, 2023
99f9c66
20-jre only supports arm64
itzg May 31, 2023
63008fa
20-jre only supports arm64, not arm/v7
itzg May 31, 2023
a9f5c69
20-jre only supports arm64, not arm/v7
itzg May 31, 2023
355f595
Test image needs amd64 not arm64
itzg May 31, 2023
9f6e743
Clarify arm64 test image
itzg May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-multiarch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
# JAVA 20:
- variant: java20
baseImage: eclipse-temurin:20-jre
platforms: linux/amd64,linux/arm/v7,linux/arm64
platforms: linux/amd64,linux/arm64
mcVersion: 1.19.3
- variant: java20-alpine
baseImage: eclipse-temurin:20-jre-alpine
Expand Down
20 changes: 16 additions & 4 deletions .github/workflows/verify-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,18 @@ jobs:
# JAVA 20:
- variant: java20
baseImage: eclipse-temurin:20-jre
platforms: linux/amd64,linux/arm/v7,linux/arm64
mcVersion: 1.19.3
platforms: linux/amd64,linux/arm64
mcVersion: 1.19.4
# JAVA 17:
- variant: java17
# jammy doesn't work until minecraft updates to https://github.com/netty/netty/issues/12343
baseImage: eclipse-temurin:17-jre-focal
platforms: linux/amd64
mcVersion: 1.18.2
mcVersion: 1.19.4
- variant: java17-alpine
baseImage: eclipse-temurin:17-jre-alpine
platforms: linux/amd64
mcVersion: 1.18.2
mcVersion: 1.19.4
- variant: java8-multiarch
baseImage: eclipse-temurin:8u312-b07-jre-focal
platforms: linux/amd64
Expand All @@ -53,9 +53,21 @@ jobs:
- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v2

- name: Confirm multi-arch build
uses: docker/build-push-action@v3.3.0
with:
platforms: ${{ matrix.platforms }}
# ensure latest base image is used
pull: true
build-args: |
BASE_IMAGE=${{ matrix.baseImage }}
cache-from: type=gha,scope=${{ matrix.variant }}

- name: Build for test
uses: docker/build-push-action@v3.3.0
with:
# Only build single platform since loading multi-arch image into daemon fails with
# "docker exporter does not currently support exporting manifest lists"
platforms: linux/amd64
tags: ${{ env.IMAGE_TO_TEST }}
# ensure latest base image is used
Expand Down
2 changes: 1 addition & 1 deletion docs/versions/java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ When using the image `itzg/minecraft-server` without a tag, the `latest` image t
| java17-graalvm-ce | 17 | Oracle | GraalVM CE | amd64,arm64 |
| java17-alpine | 17 | Alpine | Hotspot | amd64 |
| java20-alpine | 19 | Alpine | Hotspot | amd64 |
| java20 | 19 | Ubuntu | Hotspot | amd64,arm64,armv7 |
| java20 | 19 | Ubuntu | Hotspot | amd64,arm64 |

For example, to use Java version 8 on any supported architecture:

Expand Down