Skip to content

docs: updated development notes to use jwebserver #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

docs: updated development notes to use jwebserver #2212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc8278
docs: updated development notes to use jwebserver
itzg Jun 13, 2023
7e7e621
Fixed directory
itzg Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions docs/misc/contributing/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,19 @@ In the cloned copy of [`mc-image-helper`](https://github.com/itzg/mc-image-helpe
./gradlew distTar
```

Assuming [http-server](https://www.npmjs.com/package/http-server) is installed globally, start a static web server using:
!!! note
The distribution's version will be `0.0.0-<branch>-SNAPSHOT`

Assuming Java 18 or newer:

```shell
http-server ./build/distributions -p 8080
cd build/distributions
jwebserver -b 0.0.0.0 -p 8008
```

Note the port that was selected by http-server and pass the build arguments, such as:

```shell
--build-arg MC_HELPER_VERSION=1.8.1-SNAPSHOT \
--build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8080
--build-arg MC_HELPER_BASE_URL=http://host.docker.internal:8008
```

Now the image can be built like normal, and it will install mc-image-helper from the locally built copy.
Expand Down