added support magma version tags #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The parameter, in theory, is not required and can be left empty in order to always take the latest version. |
itzg
reviewed
Jun 23, 2023
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks! Just a couple of small items.
README.md
Outdated
| > **NOTE** there are limited base versions supported, so you will also need to set `VERSION`, such as "1.12.2", "1.16.5", etc. | ||
| > **NOTE** there are limited base versions supported, so you will also need to set `VERSION`, such as "1.12.2", "1.16.5", etc. | ||
| > To switch the MAGMA version, you need to take the name of the desired tag. |
Owner
There was a problem hiding this comment.
Can you rephrase "you need to take the name of the desired tag" and/or explain how one obtains that? As written I have no idea what you're talking about, but looking at the example I'm having to guess you mean the git revision of Magma.
adamancini
pushed a commit
to adamancini/docker-minecraft-server
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with constant updates, which can theoretically break the server startup. I checked the launch of the desired version and it works fine.