Skip to content

Successful spigot/bukkit update check caused grep to fail #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Successful spigot/bukkit update check caused grep to fail #2726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docs/types-and-platforms/server-types/bukkit-spigot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# Bukkit/Spigot

!!! warning

The download provider for Bukkit/Spigot, GetBukkit, is no longer operational. It is recommended that users switch to [Paper](paper.md) instead.

This image still provides an option to build Bukkit/Spigot from source if Paper is not feasible.

Run a Bukkit/Spigot server type by setting the environment variable `TYPE` to "BUKKIT" or "SPIGOT".

!!! example
Expand Down
6 changes: 4 additions & 2 deletions scripts/start-deployBukkitSpigot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function downloadSpigot {
tempFile="$SERVER.$$"

# HTTP error or download site responded with an HTML error page
if ! curl -fsSL -o "$tempFile" "${curlArgs[@]}" "$downloadUrl" || grep -iq "doctype html" "$tempFile"; then
if ! curl -fsSL -o "$tempFile" "${curlArgs[@]}" "$downloadUrl" || ( [ -f "$tempFile" ] && grep -iq "doctype html" "$tempFile" ); then

cat <<EOF

Expand All @@ -113,7 +113,9 @@ EOF
fi

else
mv "$tempFile" "$SERVER"
if [ -f "$tempFile" ]; then
mv "$tempFile" "$SERVER"
fi

fi

Expand Down