Enhance CurseForge server packs that use variables.txt #2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Jun 1, 2024
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for enhancing this. If you add the requested conditional I'm good to merge.
scripts/start-finalExec
Outdated
| else | ||
| JVM_ARGS="${JVM_XX_OPTS} ${JVM_OPTS} $expandedDOpts" | ||
| JVM_ARGS=${JVM_ARGS//$'\n'/} | ||
| sed -i "s~JAVA_ARGS=.*~JAVA_ARGS=\"${JVM_ARGS}\"~" "${FTB_DIR}/variables.txt" |
Owner
There was a problem hiding this comment.
Please add a conditional on variables.txt file existing. One big reason I deprecated support for server modpacks is that there was no guaranteed consistency. Some embed the equivalent in their start script.
Contributor
Author
|
Conditional has been added. I have no idea how the other modpacks are structured and thought the server start sequence would be standard. Thanks for your work on this docker image. |
itzg
approved these changes
Jun 1, 2024
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for the update. Yes, you'd assume/expect consistency...but nope 😄
itzg
changed the title
sevenrats
pushed a commit
to sevenrats/docker-minecraft-server
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Curseforge server type has not been using the specified memory options. The startup logs (screenshot below) and server memory usage indicate that only 4GB is allocated regardless of the values set in the environment variables. Min 8GB, Max 16GB, and Aikar's flags have been enabled but the java args remain at -Xms4G -Xmx4G.
The issue is that the launch script used by /data/FeedTheBeast/start.sh uses the variables set in /data/FeedTheBeast/variables.txt to determine java launch options. The docker scripts set the desired launch options to variables but never write them to this file.
The proposed change replaces the current JAVA_ARGS variable in variables.txt with the ones defined within the script. Logs from the revised build show the desired result below.