Add zume to cf-exclude-include.json #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i added zume, it was producing a crash on industrial-village modpack, the creator said that it was client only.
itzg
reviewed
Jun 5, 2024
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for the update and research. It's good to go after the requested tweak.
files/cf-exclude-include.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "globalExcludes": [ | |||
| "zume", | |||
Owner
There was a problem hiding this comment.
Sorry to be picky, but can you add it in the alphabetical spot for it?
Contributor
Author
There was a problem hiding this comment.
is it okay now? maybe we should add that as a comment to the file
Owner
There was a problem hiding this comment.
Yes it is. JSON doesn't allow comments unfortunately but later I could switch the code to load as JSON5, which does.
itzg
changed the title
sevenrats
pushed a commit
to sevenrats/docker-minecraft-server
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i added zume, it was producing a crash on industrial-village modpack, the creator said that it was client only.