fix(tests): ensure Nginx is fully spun up before starting MC container #3763
Conversation
This change implements the behavior described in itzg#3762 (comment), which should help making test execution less racy.
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks! That was much easier to understand via a PR.
|
FYI, found a fix for the alpine issue. Need to exclude http3 support due to mismatch on alpine. |
|
Awesome! I'll keep looking into these mysterious failures for an unrecognized archive type when downloading test files from the web server as well... |
|
Again, the only variable that changed was the Oracle Linux upgrade. All graalvm builds were fine up to this one https://github.com/itzg/docker-minecraft-server/actions/runs/19312338293/job/55235490311 And after upgrade the next two have failed https://github.com/itzg/docker-minecraft-server/actions/runs/19382359591/job/55463367190 https://github.com/itzg/docker-minecraft-server/actions/runs/19390730903/job/55483795803 I could add graalvm as a variant to include in PR test, but I was avoiding that since it's the slowest one to build. |
2 participants
This change implements the behavior described in #3762 (comment), which should help making test execution less racy.