Added ability to add resource-pack from environment vars #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to change/add resource-pack link from environment variables. Both resource-pack and resource-pack-sha1 can be set by RESOURCE_PACK and RESOURCE_PACK_SHA1
Contributor
Author
|
I use a "clear glass" resource pack on my servers, and being able to set it via environment vars would be very useful and convenient. Maybe allowing all options to be configurable would be useful. wiki |
Added to Dockerfile default environment vars for RESOURCE_PACK and RESOURCE_PACK_SHA1 for consistency.
itzg
reviewed
Aug 22, 2019
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for this contribution. Do you mind also adding a tiny section to the README within
https://github.com/itzg/docker-minecraft-server/blob/master/README.md#server-configuration
to document this pair of options?
Added wiki entry for resoucepack options
Contributor
Author
|
Check it out, I tried to model it after the others. |
itzg
approved these changes
Aug 24, 2019
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for the docs update, especially since there's that escaping quirk.
Owner
|
This is now available on Docker Hub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to change/add resource-pack link from environment variables.
Both resource-pack and resource-pack-sha1 can be set by RESOURCE_PACK and RESOURCE_PACK_SHA1