Drop privileges before starting server #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create 'minecraft' user account within image. - Drop to 'minecraft' user before starting server.
itzg
added a commit
that referenced
this pull request
Nov 1, 2014
Drop privileges before starting server
Owner
|
I had explored the use of docker run -u <>, but I like the compromise of your solution. Thanks. (Sorry for the double comment here and your commit :) ) |
Owner
|
...and built (image ID 39e3d30e0919) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First, I'd like to say that I greatly appreciate your creating this docker image for Minecraft.
I'm sending this pull request as I had noticed that the Minecraft process was running as root, though it does not require such privileges. See the principle of least privilege. There has been at least one exploit that allowed someone with root privs within a docker container to escalate to root privs on the host system.
All that I've done is 1) add a 'minecraft' user, 2) ensure that user owns /data, and 3) execute the original startup script as the minecraft user.
thanks!