Fix minecraft shutdown #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix to allow signals to pass into the container, properly. 'docker stop ...' was resorting to SIGKILL to stop the container, which results in data loss. This change switches CMD to 'exec' mode, ensuring signals make their way to the java process so that things shut down properly.
Owner
|
I need to get out of the habit of leaving off the [ ]'s even though I know the difference. Thanks again. |
Owner
|
Built with image ID 2766efa2784e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, just one more for the day. This one fixes 'docker stop ...', which was improperly shutting down the server. With this change, you'll notice that minecraft now actually receives a shutdown signal and exit, rather than being killed (and losing data).
Fix to allow signals to pass into the container, properly.
'docker stop ...' was resorting to SIGKILL to stop the container,
which results in data loss. This change switches CMD to 'exec' mode,
ensuring signals make their way to the java process so that things
shut down properly.