Skip to content

Support comments within CF_EXCLUDE_MODS #646

@MaxLevs

Description

@MaxLevs

I don't know if it's planned change or not but it worked for quite some time. And now it doesn't (after update).

As you can see in log fragment, it says that "mod with slug 'broken' was not found".
The word "broken" only appears in comment part in the example's envs.
The thing is this "wrong slug" is different every run. Sometimes it even says that # is not a valid slug.

MC Helper version: 1.49.0, 1.48.14.

Steps to reproduce

  1. Create Java minecraft server deployment with AUTO-CURSEFORGE;
  2. Add CF_EXCLUDE_MODS environment variable with multiline value using | symbol;
  3. Add some comments using # symbol;
  4. Run deployment.

Logs

Image

Example

environment:
      TYPE: AUTO_CURSEFORGE
      CF_SLUG: "terrafirmagreg-modern"
      CF_FILE_ID: "6995614"
      CURSEFORGE_FILES: |
        bluemap
        simple-voice-chat
        spark
      CF_EXCLUDE_MODS: |
        armor-stand-shift-swap  # here and bellow are broken mods
        ambientsounds  # here and bellow are client mods
        betterf3  
        better-ping-display  
        better-third-person  
        controlling  
        craftpresence  
        fps-reducer  
        immediatelyfast  
        itemphysic-lite  
        mouse-tweaks  
        my-server-is-compatible  
        pick-up-notifier  
        searchables  
        shimmer  
        tfc-vessel-tooltip  
        unilib
        yeetusexperimentus  
        better-foliage  
        blur  
        chat-heads  
        cherished-worlds  
        client-tweaks  
        drippy-loading-screen
        dynamiclights-reforged
        embeddium  
        931925  # https://www.curseforge.com/minecraft/mc-mods/chloride
        fancymenu  
        fast-ip-ping  
        first-person-model  
        flickerfix 
        inventory-hud-forge  
        inventory-tweaks-renewed  
        konkrete  
        melody  
        model-gap-fix  
        no-report-button  
        not-enough-animations  
        oculus  

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions