forge: support 1.7.x install_profile.json #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // such as "1.7.10-Forge10.13.4.1614-1.7.10" | ||
| final String[] idParts = idNode.asText().split("-"); | ||
|
|
||
| if (idParts.length == 3) { |
There was a problem hiding this comment.
Some of the forge versions only have length 2 here. 1.7.10 sure had an annoying extra bit in the filename.
Here's 1.5.2:
"versionInfo": {
"id": "1.5.2-Forge7.8.1.738",
Owner
Author
There was a problem hiding this comment.
Great investigation. As I mentioned over in the issue, it would be awesome if you could PR the fix for this. Just reference the same issue as before.
There was a problem hiding this comment.
Suggested change
| if (idParts.length == 3) { | |
| if (idParts.length == 2 || idParts.length == 3) { |
Owner
Author
There was a problem hiding this comment.
Code suggestions can't be applied after the PR is merged. Can you create a new PR with this?
This was referenced Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #174
cc @kevinkjt2000