Skip to content

Conversation

@nashafa
Copy link

@nashafa nashafa commented Nov 10, 2025

Upgrade reactor-netty-http to 1.3.0. This new release brings Netty to 4.2 and should fix #655.

The project does appear to build without issues, though I haven't extensively tested much else. I also took a lot at potentially breaking changes in the new release notes and could not find anything immediately obvious to address. Dependabot would have probably made this upgrade this week, but I had noted the issue and was tracking a fix.

Upgrade reactor-netty-http to 1.3.0. This new release brings Netty to 4.2 and should fix itzg#655.
@nashafa nashafa marked this pull request as ready for review November 10, 2025 14:08
@itzg
Copy link
Owner

itzg commented Nov 10, 2025

Thank you for submitting this, but I prefer to only accept upgrades via dependabot or ones that I have coordinated myself. Also be sure that Java 8 compatibility is not broken with this.

I will upgrade quite a few dependencies when I work on #659 however I need to carefully coordinate that on the itzg/minecraft-server side to discontinue java8 image updates.

@itzg
Copy link
Owner

itzg commented Nov 10, 2025

Superseded by #667

@itzg itzg closed this Nov 10, 2025
@itzg
Copy link
Owner

itzg commented Nov 11, 2025

FYI with the upgrade it's better but there's still some remaining noise:

bin/mc-image-helper resolve-minecraft-version latest

WARNING: A restricted method in java.lang.System has been called
WARNING: java.lang.System::loadLibrary has been called by io.netty.util.internal.NativeLibraryUtil in an unnamed module (file:/Users/geoff/projects/mc-image-helper/build/install/mc-image-helper/lib/netty-common-4.2.7.Final.jar)
WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for callers in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Netty 4.2.2+ to resolves Java 24 warnings

2 participants