Skip to content

Conversation

@SavePointSam
Copy link

@SavePointSam SavePointSam commented Nov 14, 2025

Adds --fabric-loader-version, --forge-version, and --neoforge-version options to override modpack-declared modloader versions for install-curseforge command.

Partial fix for itzg/docker-minecraft-server#2653
Relates to itzg/docker-minecraft-server#3759

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just wondering about combining.

@SavePointSam
Copy link
Author

Updated to use a single option rather than loader specific ones

@SavePointSam SavePointSam requested a review from itzg November 14, 2025 20:31
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit pick remaining 😄

Comment on lines +978 to +984
String loaderVersion = parts.length == 2 ? parts[1] : parts[2];

// Override with custom versions if provided
if (customModLoaderVersion != null) {
log.info("Overriding mod loader version from {} to {}", loaderVersion, customModLoaderVersion);
loaderVersion = customModLoaderVersion;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty strongly about finals, so changing something to be un-final is almost a sin 😄

Now that the logic simpler, do it this way

Suggested change
String loaderVersion = parts.length == 2 ? parts[1] : parts[2];
// Override with custom versions if provided
if (customModLoaderVersion != null) {
log.info("Overriding mod loader version from {} to {}", loaderVersion, customModLoaderVersion);
loaderVersion = customModLoaderVersion;
}
final String loaderVersion;
// Override with custom versions if provided
if (customModLoaderVersion != null) {
log.info("Overriding mod loader version from {} to {}", loaderVersion, customModLoaderVersion);
loaderVersion = customModLoaderVersion;
}
else {
loaderVersion = parts.length == 2 ? parts[1] : parts[2];
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants