Skip to content

feat(k8s): ExternalName service support #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2025
Merged

feat(k8s): ExternalName service support #419

merged 4 commits into from
Jun 20, 2025

Conversation

@FedotCompot
Copy link
Contributor

@FedotCompot FedotCompot commented Jun 20, 2025 •
edited
Loading

Enables using k8s service discovery, and as consequence allows config live reload, for minecraft servers that are external to the k8s cluster.

Example usecases:

  1. there is a separate machine that runs minecraft servers that is in same LAN as k8s cluster
  2. the IP of the minecraft server is blocked in the country of some players, use mc-router as jumper point hosted on an allowed IP to bypass the block

itzg
itzg reviewed Jun 20, 2025
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Can you update the README also?

@itzg itzg added the enhancement New feature or request label Jun 20, 2025
@FedotCompot
Copy link
Contributor Author

Implemented also service port priority, the behavior was non deterministic if both ports are specified, mc-router being more specific takes precedence.

itzg
itzg reviewed Jun 20, 2025
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update. Just a typo to fix and it's good to merge.

Thanks!

@FedotCompot @itzg
fix(readme): typo
53dda4c 
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
@FedotCompot
Copy link
Contributor Author

Accepted the change!

@itzg itzg merged commit 122910c into itzg:master Jun 20, 2025
2 checks passed
@itzg
Copy link
Owner

itzg commented Jun 20, 2025

Released in https://github.com/itzg/mc-router/releases/tag/1.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itzg itzg itzg left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FedotCompot @itzg