clean of unnecessary checks, imports, calls (TheAlgorithms#7993)

Author: marksmayo

backtracking/rat_in_maze.py

@@ -88,12 +88,12 @@ def run_maze(maze: list[list[int]], i: int, j: int, solutions: list[list[int]])
         solutions[i][j] = 1
         return True
 
-    lower_flag = (not (i < 0)) and (not (j < 0))  # Check lower bounds
+    lower_flag = (not i < 0) and (not j < 0)  # Check lower bounds
     upper_flag = (i < size) and (j < size)  # Check upper bounds
 
     if lower_flag and upper_flag:
         # check for already visited and block points.
-        block_flag = (not (solutions[i][j])) and (not (maze[i][j]))
+        block_flag = (not solutions[i][j]) and (not maze[i][j])
         if block_flag:
             # check visited
             solutions[i][j] = 1

boolean_algebra/not_gate.py

@@ -34,4 +34,4 @@ def test_not_gate() -> None:
 
 if __name__ == "__main__":
     print(not_gate(0))
-    print(not_gate(1))
+    print(not_gate(1))

cellular_automata/nagel_schrekenberg.py

@@ -45,8 +45,7 @@ def construct_highway(
 
     highway = [[-1] * number_of_cells]  # Create a highway without any car
     i = 0
-    if initial_speed < 0:
-        initial_speed = 0
+    initial_speed = max(initial_speed, 0)
     while i < number_of_cells:
         highway[0][i] = (
             randint(0, max_speed) if random_speed else initial_speed

ciphers/mixed_keyword_cypher.py

@@ -42,7 +42,7 @@ def mixed_keyword(key: str = "college", pt: str = "UNIVERSITY") -> str:
         s = []
         for _ in range(len_temp):
             s.append(temp[k])
-            if not (k < 25):
+            if k >= 25:
                 break
             k += 1
         modalpha.append(s)
@@ -52,7 +52,7 @@ def mixed_keyword(key: str = "college", pt: str = "UNIVERSITY") -> str:
     k = 0
     for j in range(len_temp):
         for m in modalpha:
-            if not (len(m) - 1 >= j):
+            if not len(m) - 1 >= j:
                 break
             d[alpha[k]] = m[j]
             if not k < 25:

compression/huffman.py

@@ -56,7 +56,7 @@ def traverse_tree(root: Letter | TreeNode, bitstring: str) -> list[Letter]:
     Recursively traverse the Huffman Tree to set each
     Letter's bitstring dictionary, and return the list of Letters
     """
-    if type(root) is Letter:
+    if isinstance(root, Letter):
         root.bitstring[root.letter] = bitstring
         return [root]
     treenode: TreeNode = root  # type: ignore

data_structures/heap/min_heap.py

@@ -121,7 +121,7 @@ def insert(self, node):
         self.sift_up(len(self.heap) - 1)
 
     def is_empty(self):
-        return True if len(self.heap) == 0 else False
+        return len(self.heap) == 0
 
     def decrease_key(self, node, new_value):
         assert (

digital_image_processing/test_digital_image_processing.py

@@ -10,7 +10,7 @@
 from digital_image_processing import convert_to_negative as cn
 from digital_image_processing import sepia as sp
 from digital_image_processing.dithering import burkes as bs
-from digital_image_processing.edge_detection import canny as canny
+from digital_image_processing.edge_detection import canny
 from digital_image_processing.filters import convolve as conv
 from digital_image_processing.filters import gaussian_filter as gg
 from digital_image_processing.filters import local_binary_pattern as lbp

dynamic_programming/fizz_buzz.py

@@ -33,10 +33,9 @@ def fizz_buzz(number: int, iterations: int) -> str:
         ...
     ValueError: iterations must be defined as integers
     """
-
-    if not type(iterations) == int:
+    if not isinstance(iterations, int):
         raise ValueError("iterations must be defined as integers")
-    if not type(number) == int or not number >= 1:
+    if not isinstance(number, int) or not number >= 1:
         raise ValueError(
             """starting number must be
                          and integer and be more than 0"""

dynamic_programming/max_sub_array.py

@@ -62,8 +62,7 @@ def max_sub_array(nums: list[int]) -> int:
     current = 0
     for i in nums:
         current += i
-        if current < 0:
-            current = 0
+        current = max(current, 0)
         best = max(best, current)
     return best
 

graphs/directed_and_undirected_(weighted)_graph.py

@@ -167,7 +167,7 @@ def cycle_nodes(self):
                         and not on_the_way_back
                     ):
                         len_stack = len(stack) - 1
-                        while True and len_stack >= 0:
+                        while len_stack >= 0:
                             if stack[len_stack] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -220,7 +220,7 @@ def has_cycle(self):
                         and not on_the_way_back
                     ):
                         len_stack_minus_one = len(stack) - 1
-                        while True and len_stack_minus_one >= 0:
+                        while len_stack_minus_one >= 0:
                             if stack[len_stack_minus_one] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -392,7 +392,7 @@ def cycle_nodes(self):
                         and not on_the_way_back
                     ):
                         len_stack = len(stack) - 1
-                        while True and len_stack >= 0:
+                        while len_stack >= 0:
                             if stack[len_stack] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break
@@ -445,7 +445,7 @@ def has_cycle(self):
                         and not on_the_way_back
                     ):
                         len_stack_minus_one = len(stack) - 1
-                        while True and len_stack_minus_one >= 0:
+                        while len_stack_minus_one >= 0:
                             if stack[len_stack_minus_one] == node[1]:
                                 anticipating_nodes.add(node[1])
                                 break