Properly set qualification properties #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not in debug mode, use a simpler EDTFParseException rather than returning the full pyparsing error
Includes handling for empty or null input strings and null errs passed to the constructor Co-Authored-By: aweakley <224316+aweakley@users.noreply.github.com>
Make the string representation of TestEvent simpler
Properly set qualification properties on - UncertainOrApproximate - Unspecified - Level1Interval - PartialUncertainOrApproximate - Level2Interval Adds tests to check that each EDTF object is parsed and that .is_approximate, .is_uncertain, and .is_uncertain_and_approximate are set to what we expect them to be
aweakley
requested changes
Jun 11, 2024
Member
aweakley
left a comment
aweakley
left a comment
There was a problem hiding this comment.
I've just made a couple of comments @ColeDCrawford
edtf/parser/parser_classes.py
Outdated
| all_ua, | ||
| ] | ||
| self.is_uncertain = any( | ||
| item.is_uncertain for item in uas if hasattr(item, "is_approximate") |
Member
There was a problem hiding this comment.
I think this should be is_uncertain
README.md
Outdated
| False | ||
|
|
||
| >>> parse_edtf("2004?-~06-~04") | ||
| PartialUncertainOrApproximate: '2004?-~06-~04'>>> L2_PartialUncertainOrApproximate.is_approximate |
Member
|
Thank you, this looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackle #31 by setting qualification properties on
This PR also adds tests to check that each EDTF object is parsed and that
.is_approximate,.is_uncertain, and.is_uncertain_and_approximateare set to what we expect them to be. It also adds some documentation about these properties.Branched off of PR #59