Added reasonPhraseExtended() #2
Conversation
…dable description text Added some missing code
j-ulrich
left a comment
j-ulrich
left a comment
There was a problem hiding this comment.
@jjberry314
Thank you for your contribution! I appreciate that!
Please let me know if you don't want to take care of my review comments, then I will do it.
|
I think, on reflection, my changes can be discarded if you wish. I don't think I need reasonPhraseExtended() at all now. If my other tweaks are useful then please feel free to adopt them, or just reject the pull request. |
…ch emits only code + phrase rather than a description
|
I've replaced reasonPhraseExtended() and replaced it with reasonPhraseEx() which emits "HTTP code: phrase" where a phrase is available or "HTTP code" if not. I have not addressed your other review comments at this time. I have no strong feeling about keeping those changes, as I don't really need them. I'm happy to revert them. |
Sorry, but IMO the format of that string is application specific and therefore does not belong into the library. Someone else might need such a message to be formatted like "HTTP <code> - <phrase>" or "<phrase> (<code>)" or whatever. So I will now create a separate pull request to add the missing status codes but leave out the |
|
I completely understand and accept your reasoning. Thank you for being so patient with me. |
2 participants
Added reasonPhraseExtended() to allow retrieval of extended human-readable description text
Added some missing codes