Skip to content

Conversation

@j178
Copy link
Owner

@j178 j178 commented Aug 6, 2025

Closes #366

@j178 j178 added the bug Something isn't working label Aug 6, 2025
@j178 j178 merged commit e7e227a into master Aug 6, 2025
15 checks passed
@j178 j178 deleted the stage branch August 6, 2025 10:33
@potiuk
Copy link

potiuk commented Aug 6, 2025

nice :)

@ashb
Copy link

ashb commented Aug 8, 2025

@j178 A nit I've noticed on this one: pre-commit run my-hook-with-stage-manual will always work, but after this change I have to manually specify prek run --hook-stage manual my-hook-with-stage-manual

@j178
Copy link
Owner Author

j178 commented Aug 8, 2025

@ashb Interesting! I tried running pre-commit run my-hook-with-stage-manual and it didn’t work for me. I checked out the pre-commit source code here:

https://github.com/pre-commit/pre-commit/blob/72a3b71f0e7b89b78899739aeee2e962914ab649/pre_commit/commands/run.py#L423-L428

It looks like it’s filtering hooks by both hook-id and stage. Could you double-check that part?

@ashb
Copy link

ashb commented Aug 8, 2025

.... You are correct. I could have sworn that worked before. I must be an AI (i.e. hallucinating)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stages: ["manual"] is run via prefligit run -a

4 participants