Add getSpatial to GhostControl, RigidBodyControl, AbstractPhysicsCont… #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol and CharacterControl. Fix issue 1008
Member
|
Nice work. One correction: spatials are not attached to controls; controls are added to spatials. Could you please change the javadoc accordingly? |
Contributor
Author
|
It there a way to write it more clearly? I am not sure if it's the best way to write it. |
Member
|
The way you have it is okay. |
Contributor
Author
|
Then perhaps the doc should say, |
Member
|
Sure. Sounds good. |
Member
|
Okay, I think this is ready to integrate. I'll leave it open another day in case anyone else wants to review it. |
Contributor
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rol and CharacterControl. Fix issue #1008