Skip to content

resolve issue 1446 (test whether an EnvironmentCamera is busy) #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2021
Merged

resolve issue 1446 (test whether an EnvironmentCamera is busy) #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3958ef
resolve issue #1446 (test whether an EnvironmentCamera is busy)
stephengold Mar 24, 2021
097090e
RefEnv: indicate whether the EnvironmentCamera is busy (to test 1446)
stephengold Mar 24, 2021
1461bb6
EnvironmentCamera: clearer coding of render() method
stephengold Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 33 additions & 20 deletions jme3-core/src/main/java/com/jme3/environment/EnvironmentCamera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,28 +172,30 @@ public Void call() throws Exception {

@Override
public void render(final RenderManager renderManager) {
if (isBusy()) {
final SnapshotJob job = jobs.get(0);

for (int i = 0; i < 6; i++) {
viewports[i].clearScenes();
viewports[i].attachScene(job.scene);
renderManager.renderViewPort(viewports[i], 0.16f);
buffers[i] = BufferUtils.createByteBuffer(
size * size * imageFormat.getBitsPerPixel() / 8);
renderManager.getRenderer().readFrameBufferWithFormat(
framebuffers[i], buffers[i], imageFormat);
images[i] = new Image(imageFormat, size, size, buffers[i],
ColorSpace.Linear);
MipMapGenerator.generateMipMaps(images[i]);
}

if (jobs.isEmpty()) {
return;
}

final SnapshotJob job = jobs.get(0);

for (int i = 0; i < 6; i++) {
viewports[i].clearScenes();
viewports[i].attachScene(job.scene);
renderManager.renderViewPort(viewports[i], 0.16f);
buffers[i] = BufferUtils.createByteBuffer(size * size * imageFormat.getBitsPerPixel() / 8);
renderManager.getRenderer().readFrameBufferWithFormat(framebuffers[i], buffers[i], imageFormat);
images[i] = new Image(imageFormat, size, size, buffers[i], ColorSpace.Linear);
MipMapGenerator.generateMipMaps(images[i]);
}

final TextureCubeMap map = EnvMapUtils.makeCubeMap(images[0], images[1], images[2], images[3], images[4], images[5], imageFormat);
final TextureCubeMap map = EnvMapUtils.makeCubeMap(images[0],
images[1], images[2], images[3], images[4], images[5],
imageFormat);
debugEnv = map;
job.callback.done(map);
map.getImage().dispose();
jobs.remove(0);
job.callback.done(map);
map.getImage().dispose();
jobs.remove(0);
}
}

/**
Expand Down Expand Up @@ -276,6 +278,17 @@ public ViewPort[] getViewPorts(){
return viewports;
}

/**
* Test whether this EnvironmentCamera is busy. Avoid reconfiguring while
* busy!
*
* @return true if busy, otherwise false
*/
public boolean isBusy() {
boolean result = !jobs.isEmpty();
return result;
}

@Override
protected void initialize(Application app) {
this.backGroundColor = app.getViewPort().getBackgroundColor().clone();
Expand Down
7 changes: 6 additions & 1 deletion jme3-examples/src/main/java/jme3test/light/pbr/RefEnv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ private void switchMat(Spatial s) {
public void simpleUpdate(float tpf) {
frame++;

EnvironmentCamera eCam = stateManager.getState(EnvironmentCamera.class);
if (frame == 2) {
final LightProbe probe = LightProbeFactory.makeProbe(stateManager.getState(EnvironmentCamera.class), rootNode, EnvMapUtils.GenerationType.Fast, new JobProgressAdapter<LightProbe>() {
final LightProbe probe = LightProbeFactory.makeProbe(eCam, rootNode, EnvMapUtils.GenerationType.Fast, new JobProgressAdapter<LightProbe>() {

@Override
public void done(LightProbe result) {
Expand All @@ -161,5 +162,9 @@ public void done(LightProbe result) {
rootNode.addLight(probe);

}

if (eCam.isBusy()) {
System.out.println("EnvironmentCamera busy as of frame " + frame);
}
}
}