Improved ShaderNodes #430
Merged
Improved ShaderNodes #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed a NPE when trying to select a Node. Now you can properly remove/edit nodes * "smartLog" now compares the hash across different instances (Two Material Previews led to duplicate log messages) * Using smartLog for CompilationErrors now to not spam the log with 60 FPS
Contributor
|
Well there could be more than 3 renderers in the future, if we use MRT. |
Nehon
added a commit
that referenced
this pull request
Feb 28, 2016
Improved ShaderNodes, fixed some issues with error management and crash when selecting some nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lookup failed because there was no Instance of
MatDefNavigatorPanel.Now everything works as intended (You can remove Nodes, change their properties, or at least select them without a crash.)
When you produce a shader compilation error, you have the same error printed three times (wireframe (geometry), solid (color) and a third). This doesn't happen anymore, since the hash is now static.
However I am uncertain because of such an example:
When you have two instances, one constantly printing a and one constantly printing b. Then smartLog wouldn't work. Since we have three Renderers with the same Material this is very unlikely.