Skip to content

Conversation

@jackd248
Copy link
Owner

@jackd248 jackd248 commented Oct 13, 2025

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to use the latest Rector package and cleaned up the dev requirements.
  • Refactor
    • Migrated automated refactoring configuration to a new fluent format, aligning paths, PHP version, rule sets, and composer-based framework detection.
  • Style
    • Minor formatting adjustments in the development dependency block.
  • Note
    • No user-facing changes; application behavior remains unchanged.

@coderabbitai
Copy link

coderabbitai bot commented Oct 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates development dependencies to use rector/rector ^2.2 and removes eliashaeussler/rector-config. Migrates Rector configuration to the new fluent RectorConfig::configure() API, adjusts path, PHP version, set list, composer-based integration, and specifies AddVoidReturnTypeWhereNoReturnRector in withRules.

Changes

Cohort / File(s) Summary of Changes
Dev dependency update
composer.json
Removed eliashaeussler/rector-config from require-dev; added rector/rector with version ^2.2; minor formatting adjustment in require-dev block.
Rector config migration
rector.php
Replaced legacy Config::create/closure style with RectorConfig::configure() chain; switched in(...) to withPaths([...]); set PHP version via withPhpVersion(PhpVersion::PHP_81); added withSets([LevelSetList::UP_TO_PHP_81]); enabled withComposerBased(symfony: true); consolidated rules with withRules([AddVoidReturnTypeWhereNoReturnRector::class]).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant CLI as Rector CLI
  participant Cfg as RectorConfig (fluent)
  participant Rules as Rules Engine

  Dev->>CLI: run rector
  CLI->>Cfg: load rector.php
  Note right of Cfg: Configure via withPaths, withPhpVersion,<br/>withSets, withComposerBased, withRules
  Cfg-->>CLI: return configured RectorConfig
  CLI->>Rules: apply configured rules
  Rules-->>CLI: transformations for codebase
  CLI-->>Dev: report changes
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge my whiskers at configs anew,
Hopping from old to fluent view.
Rector 2 hums, paths align,
PHP 8.1—carrots in a line.
With rules in tow, I thump in cheer—
Clean burrows, tidy code, no fear! 🥕🐇

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch simplify-rector

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d11ce6 and cb2514b.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • composer.json (1 hunks)
  • rector.php (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jackd248 jackd248 merged commit 547d882 into main Oct 13, 2025
11 of 12 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18464123845

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 18463760383: 0.0%
Covered Lines: 260
Relevant Lines: 260

💛 - Coveralls

@jackd248 jackd248 deleted the simplify-rector branch October 23, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants