refactor: replace hardcoded skipPreNav with declarative navigateBefore field#208
Merged
refactor: replace hardcoded skipPreNav with declarative navigateBefore field#208
Conversation
…e field Browser adapters using COOKIE/HEADER strategy need the page on the target domain so credentialed fetch() carries cookies. Previously, execution.ts hardcoded `cmd.site === 'boss'` to skip this pre-navigation for adapters that handle their own goto(). Now each adapter self-declares via `navigateBefore: false` on CliCommand. This is more extensible — new sites that manage their own navigation just add the field instead of editing execution.ts. Changes: - Add `navigateBefore?: boolean | string` to CliCommand interface - Add `resolvePreNav()` helper in execution.ts (replaces hardcoded check) - All 14 boss adapters declare `navigateBefore: false` - Wire through discovery.ts (YAML + manifest) and build-manifest.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded cmd.site===boss check in execution.ts with a declarative navigateBefore field on CliCommand. Each adapter self-declares whether it needs pre-navigation for cookie context. All 14 boss adapters set navigateBefore:false. Fully backward compatible.