fix: resolve inconsistent doctor --live report (fix #121)#224
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 22, 2026
Merged
Conversation
Instead of calling checkDaemonStatus() twice (before and after the connectivity check), reorder so that the live connectivity check runs first, then read daemon status only once. This: - Eliminates redundant checkDaemonStatus() call - Naturally avoids the timing inconsistency (fixes jackwener#121) - Also fixes the sessions query using stale status - Simplifies test assertions to avoid over-coupling to exact wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复了issue #121：--live 执行后会重新读取一次状态，再生成最终报告，改动在 src/doctor.ts。另外补了一条回归测试，覆盖“初始未运行，但 live 检查启动了 daemon”的场景，见 src/doctor.test.ts。
验证我已经跑过：npm test -- src/doctor.test.ts，6 个测试都通过。